Change in ovirt-engine[master]: engine: Removed AddVmPoolCommand class

[ofrenkel at redhat.com]

Omer Frenkel has submitted this change and it was merged.

Change subject: engine: Removed AddVmPoolCommand class
......................................................................


engine: Removed AddVmPoolCommand class

Removed AddVmPoolCommand class, because it is no longer used:

1. VdcActionType.AddVmPool is never used.
2. CommonVmPoolWithVmsCommand extends AddVmPoolCommand, but this
   inheritance is useless:
  a. AddVmPoolCommand.executeCommand() is never called from
     CommonVmPoolWithVmsCommand.executeCommand(), the same work is done
     by AddVmPoolWithVmsCommand.getPoolId().
  b. AddVmPoolCommand.getAuditLogTypeValue() is never called.
  c. AddVmPoolCommand.getValidationGroups() does the same as
     AddVmPoolWithVmsCommand.getValidationGroups() and was merged to
     UpdateVmPoolWithVmsCommand.getValidationGroups().
  d. AddVmPoolCommand() constructor code is merged to
     CommonVmPoolWithVmsCommand() constructor.
3. The hierarchy where UpdateVmPoolWithVmsCommand is inherited
   indirectly from AddVmPoolCommand seems illogical.

Change-Id: I6941ff975c7051d14a077dc7126b59b5e0fea114
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
6 files changed, 4 insertions(+), 53 deletions(-)

Approvals:
  Shmuel Leib Melamud: Verified
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/39337
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6941ff975c7051d14a077dc7126b59b5e0fea114
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server