Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine : Refactoring in accordance with vdsm patches

sabose at redhat.com sabose at redhat.com
Wed Apr 8 08:20:04 UTC 2015


Sahina Bose has submitted this change and it was merged.

Change subject: engine : Refactoring in accordance with vdsm patches
......................................................................


engine : Refactoring in accordance with vdsm patches

This patch does the following :

1. The geo-rep engine patches were merged before the corresponding
patches and hence at merge time, contained the exception codes and
api names as the vdsm exposed at that time.
       Now, that the vdsm patches have been merged, this patch
refactors the engine side accordingly.
2. StartGlusterVolumeGeoRepCommand was modifying the status of geo-rep
session in db on success. But, it is observed that the session on gluster
side takes a while to change state to ACTIVE untill then it stays as
INITIALISING and hence this patch removes the state change code and allows
the geo-rep sync job to detect state change.

Change-Id: I702d6c62f576cf2a49437fcf37155290d8580588
Signed-off-by: Anmol Babu <anbabu at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/PauseGlusterVolumeGeoRepSessionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeGeoRepCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepSessionStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/PauseGlusterVolumeGeoRepSessionVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/ResumeGeoRepSessionVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StartGlusterVolumeGeoRepVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
17 files changed, 58 insertions(+), 47 deletions(-)

Approvals:
  Sahina Bose: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/39639
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I702d6c62f576cf2a49437fcf37155290d8580588
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list