Change in ovirt-engine[master]: userportal, webadmin: Make ElementTooltip.setContent() null-...

[tjelinek at redhat.com]

Tomas Jelinek has submitted this change and it was merged.

Change subject: userportal, webadmin: Make ElementTooltip.setContent() null-safe
......................................................................


userportal, webadmin: Make ElementTooltip.setContent() null-safe

Setting ElementTooltip.content to null will cause exception in
ElementTooltip.reconfigure(). This happens, for example, in
MainTabBasicListItemView.addRunButton(), where the button is created
with tooltip set to null.

To avoid this error, ElementTooltip.content is initialised with
SafeHtmlUtils.EMPTY_SAFE_HTML instead of null and
ElementTooltip.setContent() also handles null safely.

Change-Id: If7d4f172c6caf1b42222cd571bfe3536ae6a8aa6
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/ElementTooltip.java
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Martin Betak: Looks good to me, but someone else must approve
  Shmuel Leib Melamud: Verified

Objections:
  oVirt Jenkins CI Server: Fails



-- 
To view, visit https://gerrit.ovirt.org/39610
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If7d4f172c6caf1b42222cd571bfe3536ae6a8aa6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server