Change in ovirt-engine[master]: core: QuotaStorageDependent removal in ExtendImageSizeCommand.

amureini at redhat.com amureini at redhat.com
Thu Apr 16 08:33:46 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: QuotaStorageDependent removal in ExtendImageSizeCommand.
......................................................................


core: QuotaStorageDependent removal in ExtendImageSizeCommand.

ExtendImageSizeCommand currently implements QuotaStorageDependent which deals with
quota consumptions. The command is being called in UpdateVmDiskCommand
in case the disk size is extended, but never reaches the actual consume
part in the code as it is constructed as an unquota-dependent command.

Moreover, UpdateDiskCommand deals with any case of quota consumption
(introduced in https://gerrit.ovirt.org/#/c/39330/,
BZ: https://bugzilla.redhat.com/1203262 )

So dealing with that is not needed in that command.

Change-Id: I940ab5817cb09e4f6275cbda713ecc37a4bd74fc
Signed-off-by: Amit Aviram <aaviram at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExtendImageSizeCommand.java
1 file changed, 1 insertion(+), 23 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/39866
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I940ab5817cb09e4f6275cbda713ecc37a4bd74fc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list