Change in ovirt-engine[master]: engine: Extract common interface logic to single method

lvernia at redhat.com lvernia at redhat.com
Sun Apr 26 13:40:14 UTC 2015


Lior Vernia has submitted this change and it was merged.

Change subject: engine: Extract common interface logic to single method
......................................................................


engine: Extract common interface logic to single method

The same code was duplicated across interfaces, bonds and VLANs,
whereas it could be re-used.

Change-Id: I495f36cea0a63a161ca4ae85fc08e67e718befa2
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 56 insertions(+), 70 deletions(-)

Approvals:
  Martin Mucha: Looks good to me, but someone else must approve
  Moti Asayag: Looks good to me, approved
  Lior Vernia: Verified



-- 
To view, visit https://gerrit.ovirt.org/37078
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I495f36cea0a63a161ca4ae85fc08e67e718befa2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list