Change in ovirt-engine[master]: backend: initAppsList should not process null objects

ofrenkel at redhat.com ofrenkel at redhat.com
Wed Apr 29 08:53:15 UTC 2015


Omer Frenkel has submitted this change and it was merged.

Change subject: backend: initAppsList should not process null objects
......................................................................


backend: initAppsList should not process null objects

If the appsList contains non-strings or null values, a
null value would have been passed to the string builder.

This patch handles these cases and warns about wrong types
in the appsList.

Change-Id: Ia51bb09466a870695c0457679362f34ec9f6202f
Signed-off-by: Vinzenz Feenstra <vfeenstr at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, but someone else must approve
  Vinzenz Feenstra: Verified
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/40381
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia51bb09466a870695c0457679362f34ec9f6202f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list