Change in ovirt-engine[master]: core: Add hamcrest-library as an explicit test dependency

masayag at redhat.com masayag at redhat.com
Thu Apr 30 10:05:09 UTC 2015


Moti Asayag has submitted this change and it was merged.

Change subject: core: Add hamcrest-library as an explicit test dependency
......................................................................


core: Add hamcrest-library as an explicit test dependency

The jar includes useful unit-test utilities
(e.g. different Matcher implementations). Currently the dependency
is obtained transitively through spring-boot-starter-test,
which is going to be removed.

That patch is the better implementation of
https://gerrit.ovirt.org/40149.

Change-Id: Idbec3ea20820972e1daf4981846290c40163b257
Signed-off-by: Yevgeny Zaspitsky <yzaspits at redhat.com>
---
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/dc/GetManagementNetworkCandidatesQueryTest.java
M pom.xml
3 files changed, 10 insertions(+), 2 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Moti Asayag: Looks good to me, approved
  Yevgeny Zaspitsky: Verified



-- 
To view, visit https://gerrit.ovirt.org/40362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idbec3ea20820972e1daf4981846290c40163b257
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list