Change in ovirt-engine[master]: packaging: setup: vmconsole: cleanup config module

sbonazzo at redhat.com sbonazzo at redhat.com
Mon Aug 3 08:25:55 UTC 2015


Sandro Bonazzola has submitted this change and it was merged.

Change subject: packaging: setup: vmconsole: cleanup config module
......................................................................


packaging: setup: vmconsole: cleanup config module

add devenv specific notes to README.developer, remove from runtime.

a config file that can be processed using a template during build time
should not be generated at runtime.

remove unused Makefile substitutions.

use better naming for vmconsole proxy configuration we provide.

Change-Id: I4605019e7430cc28e6be2d0eea3ca41503f7bff3
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M .gitignore
M Makefile
M README.developer
M ovirt-engine.spec.in
A packaging/conf/ovirt-vmconsole-proxy.conf.in
M packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/config.py.in
M packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/constants.py
M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py
8 files changed, 42 insertions(+), 97 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified; Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/44174
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4605019e7430cc28e6be2d0eea3ca41503f7bff3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list