Change in ovirt-engine[master]: webadmin: Handle null and empty list values in ListModelMult...

rgolan at redhat.com rgolan at redhat.com
Tue Aug 4 16:06:24 UTC 2015


Roy Golan has submitted this change and it was merged.

Change subject: webadmin: Handle null and empty list values in ListModelMultipleSelectListBox
......................................................................


webadmin: Handle null and empty list values in ListModelMultipleSelectListBox

The code assumed the values are always passed which isn't the case for
new clusters and that caused NPE in GWT and dialogs to appear stuck on
loading.

Change-Id: I77fd69736080eb253f0c3259bda6e3108a2493a2
Bug-Url: https://bugzilla.redhat.com/1248509
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelMultipleSelectListBox.java
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Roy Golan: Verified
  Omer Frenkel: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/44359
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I77fd69736080eb253f0c3259bda6e3108a2493a2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list