Change in ovirt-engine[master]: webadmin, userportal: Cache of VmConsoles removed

tjelinek at redhat.com tjelinek at redhat.com
Wed Aug 5 10:44:32 UTC 2015


Tomas Jelinek has submitted this change and it was merged.

Change subject: webadmin, userportal: Cache of VmConsoles removed
......................................................................


webadmin, userportal: Cache of VmConsoles removed

VmConsoles objects are not cached, rather created on demand thus they
can be well configured all the time.

The bug was caused by resolving wrong console type during first list
show (when the vms were down) and keeping that settings even after vms
were capable of non-rdp connection.

Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
Change-Id: I92fd4807a9d2daea67b8ba547c75717a1764268d
Bug-Url: https://bugzilla.redhat.com/1236674
---
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleModelsCache.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsolesFactory.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
7 files changed, 102 insertions(+), 165 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/44179
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I92fd4807a9d2daea67b8ba547c75717a1764268d
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list