Change in ovirt-engine[master]: core: Move messages to the right place

amureini at redhat.com amureini at redhat.com
Wed Aug 5 13:11:53 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Move messages to the right place
......................................................................


core: Move messages to the right place

Messages from EngineError should be I18Ned in the VdsmErrors files, not
the AppErrors files.

This patch moves the misplaced messages to their correct files and
amends AbstractPropertiesTestBase to ensure it.

Change-Id: I06248e23e32b7ca2e7f3397e8c0e28e24eb20bf5
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/AbstractPropertiesTestBase.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
9 files changed, 19 insertions(+), 26 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Allon Mureinik: Verified
  Moti Asayag: Looks good to me, but someone else must approve
  Oved Ourfali: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/44365
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I06248e23e32b7ca2e7f3397e8c0e28e24eb20bf5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list