Change in ovirt-engine[master]: test: Mock CpuFlagsManagerHandler in AddVmTemplateCommandTest

ofrenkel at redhat.com ofrenkel at redhat.com
Sun Aug 9 09:50:26 UTC 2015


Omer Frenkel has submitted this change and it was merged.

Change subject: test: Mock CpuFlagsManagerHandler in AddVmTemplateCommandTest
......................................................................


test: Mock CpuFlagsManagerHandler in AddVmTemplateCommandTest

Added CpuFlagsManagerHandler mock into AddVmTemplateCommandTest, because
it calls VmHandler.init() that's failing in absence of
CpuFlagsManagerHandler.

Also InjectorRule was made non-static to avoid dependency between tests.

Change-Id: I579539ebe469da6587f24a9c445271e86161e0c9
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java
5 files changed, 19 insertions(+), 11 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Verified
  Omer Frenkel: Looks good to me, approved
  Yevgeny Zaspitsky: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/44492
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I579539ebe469da6587f24a9c445271e86161e0c9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list