Change in ovirt-engine[master]: engine: fix findBugs warning DC_DOUBLECHECK

ofrenkel at redhat.com ofrenkel at redhat.com
Wed Aug 12 05:41:35 UTC 2015


Omer Frenkel has submitted this change and it was merged.

Change subject: engine: fix findBugs warning DC_DOUBLECHECK
......................................................................


engine: fix findBugs warning DC_DOUBLECHECK

Fix findBugs warning DC_DOUBLECHECK.

Possible doublecheck on instance in GlusterSyncJob.getInstance().

This method may contain an instance of double-checked locking.
This idiom is not correct according to the semantics of the
Java memory model.
For more information, see the web page
http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html.

Change-Id: I9a7128bde99e0284dd5f06c7bf5ad5f02b3afd93
Signed-off-by: Yevgeny Zaspitsky <yzaspits at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Sahina Bose: Looks good to me, approved
  Omer Frenkel: Looks good to me, but someone else must approve
  Yevgeny Zaspitsky: Verified



-- 
To view, visit https://gerrit.ovirt.org/44682
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9a7128bde99e0284dd5f06c7bf5ad5f02b3afd93
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list