Change in ovirt-engine[master]: host-deploy: remove timestamp cache check for tarball

masayag at redhat.com masayag at redhat.com
Sun Aug 16 07:50:16 UTC 2015


Moti Asayag has submitted this change and it was merged.

Change subject: host-deploy: remove timestamp cache check for tarball
......................................................................


host-deploy: remove timestamp cache check for tarball

when multiple packages manage the directory tree, the last file
timestamp cannot be used as reference to cache integrity as an older
package may be applied after newer one.

we could have used hash mechanism, but then we had to read files once
per hash and once per creation, so better to just create the tarball at
designated interval.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252364
Change-Id: I97fa20e0f5205ebddb6aff1cbfebf3f2879fa34e
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/CachedTar.java
1 file changed, 4 insertions(+), 49 deletions(-)

Approvals:
  Alon Bar-Lev: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/44690
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I97fa20e0f5205ebddb6aff1cbfebf3f2879fa34e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list