Change in ovirt-engine[master]: restapi: Fix the cardinality storage connection extensions

juan.hernandez at redhat.com juan.hernandez at redhat.com
Tue Aug 18 13:04:44 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Fix the cardinality storage connection extensions
......................................................................


restapi: Fix the cardinality storage connection extensions

Currently the storage connection extensions element of the host entity
is declared in the XML schema with an unbounded upper limit. This means
that the corresponding Java method generated by the XJC compiler will
return a list of elements:

  List<StorageConnectionExtensions> getStorageConnectionExtensions() {
   ...
  }

This is incorrect and it causes an issue in the generator of the Java
SDK, as the code generator assumes that this kind of attribute will have
a getter that returns only one element:

  HostStorageConnectionExtensions getStorageConnectionExtensions() {
    ...
  }

The net result is a compilation problem in the generated SDK.

To avoid this issue this patch fixes the XML schema for this element so
that the upper limit is 1 instead of unbounded.

Change-Id: I7f64d74ddc31d5f2634855e31548fa0342e7a281
Bug-Url: https://bugzilla.redhat.com/1254295
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Juan Hernandez: Verified; Passed CI tests
  Amit Aviram: Looks good to me, but someone else must approve
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/44986
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7f64d74ddc31d5f2634855e31548fa0342e7a281
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list