Change in ovirt-engine[master]: restapi: refactored out updateActionTypeForQosType method

tjelinek at redhat.com tjelinek at redhat.com
Mon Aug 24 12:00:40 UTC 2015


Tomas Jelinek has submitted this change and it was merged.

Change subject: restapi: refactored out updateActionTypeForQosType method
......................................................................


restapi: refactored out updateActionTypeForQosType method

• this code does not belong into update/add method (also making it
overgrown)

• not initializating 'updateActionType' variable causes NPE much later
in process without sensible explanation.

Change-Id: Ic16d1488a932b49a4fedea3247c2e00cf06f6c5c
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQosResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosMapper.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosTypeMapper.java
4 files changed, 105 insertions(+), 48 deletions(-)

Approvals:
  Ori Liel: Looks good to me, approved
  Martin Mucha: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/41468
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic16d1488a932b49a4fedea3247c2e00cf06f6c5c
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list