Change in ovirt-engine[master]: core: Fix, retrieve dedicatedHostList on new VmNumaNode resu...

[rgolan at redhat.com]

Roy Golan has submitted this change and it was merged.

Change subject: core: Fix, retrieve dedicatedHostList on new VmNumaNode result NPE
......................................................................


core: Fix, retrieve dedicatedHostList on new VmNumaNode result NPE

The dedicatedHostList is passed to VmNumaNodeCommand in parameters.
Retrieving the VM from parent command result in NPE.
getVm() returns null, because it query on vms view.
The VM is not registered in vms view until it saves its vm_statistics
record and vm_dynamic record as well.
The best practice is to pass and read parameters.

This bug broke the REST api as well.

Change-Id: I4b63a76d9b7e40077dd39605d3aabb0a54b82dcf
Bug-Url: http://bugzilla.redhat.com/1254665
Signed-off-by: Dudi Maroshi <dudi at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Dudi Maroshi: Verified
  Jenkins CI: Passed CI tests
  Tomer Saban: Looks good to me, but someone else must approve
  Roy Golan: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/45191
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4b63a76d9b7e40077dd39605d3aabb0a54b82dcf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi at redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban at redhat.com>
Gerrit-Reviewer: automation at ovirt.org