Change in ovirt-engine[master]: core: Avoid too many IDE or sPAPR VSCSI devices

shavivi at redhat.com shavivi at redhat.com
Sun Aug 23 11:35:37 UTC 2015


Shahar Havivi has submitted this change and it was merged.

Change subject: core: Avoid too many IDE or sPAPR VSCSI devices
......................................................................


core: Avoid too many IDE or sPAPR VSCSI devices

If there are any payload devices or cloud-init is enabled, it is
possible to exceed the number of allowed sPAPR VSCSI (in ppc64) or IDE
(in x86-64) devices by having the virtual CD, the payload device and
a large number of disks in these interfaces.

This patch warns the user if that is the case and prevents the VM from
running.

Change-Id: Ief86ea10237c931490b96affaa2f97e32d617c3b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1076488
Signed-off-by: Shahar Havivi<shavivi at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/architecture/HasMaximumNumberOfDisks.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 81 insertions(+), 1 deletion(-)

Approvals:
  Shahar Havivi: Verified; Passed CI tests
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/44816
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ief86ea10237c931490b96affaa2f97e32d617c3b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list