Change in ovirt-engine[ovirt-engine-3.6]: engine: Remove Host Network QoS commitment validation
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Fri Aug 28 09:01:10 UTC 2015
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: Remove Host Network QoS commitment validation
......................................................................
engine: Remove Host Network QoS commitment validation
Since the speed reported by the host is not reliable (and in a lot of
cases, not even exists), this check doesn't have any added value
(and just makes it difficult for the user to configure qos on a nic).
Bug-Url: https://bugzilla.redhat.com/1249654
Change-Id: I109463874e29c5388837461805ca32a7baf925f1
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/InterfacesSpeed.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
10 files changed, 3 insertions(+), 461 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45210
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I109463874e29c5388837461805ca32a7baf925f1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
More information about the Engine-commits
mailing list