Change in ovirt-engine[master]: core: Remove StoragePoolValidatorForTesting

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: Remove StoragePoolValidatorForTesting
......................................................................


core: Remove StoragePoolValidatorForTesting

Removed StoragePoolValidatorForTesting and replaced the way it handled
DAO mocks with direct mocking.

This test was too "deep" - UpdateStoragePoolCommandTest should test the
logic in UpdateStoragePoolCommand, not the logic in the validators it
uses.

Change-Id: Iae0602e65c66becd3353deb97d4152b619b8587a
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
1 file changed, 9 insertions(+), 14 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/45130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iae0602e65c66becd3353deb97d4152b619b8587a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org