Change in ovirt-engine[master]: core: Stop mocking sdList

amureini at redhat.com amureini at redhat.com
Sun Aug 30 20:51:20 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Stop mocking sdList
......................................................................


core: Stop mocking sdList

java.util.List is part of the JDK, and its implementations can be
trusted - There's no reason to mock it instead of using a concrete one.

Change-Id: I3c304a1d725be369a010e5c0ea5f76a2b117a222
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
1 file changed, 4 insertions(+), 10 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Idan Shaby: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/45047
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3c304a1d725be369a010e5c0ea5f76a2b117a222
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list