Change in ovirt-engine[ovirt-engine-3.6]: core: Allow to remove Hosted Engine direct lun disks only

tnisan at redhat.com tnisan at redhat.com
Tue Dec 1 14:50:34 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: Allow to remove Hosted Engine direct lun disks only
......................................................................


core: Allow to remove Hosted Engine direct lun disks only

In order to allow importing hosted engine disks we need to allow
removing them prior to the import. Still, removing any other type of
hosted engine disks is banned.

Change-Id: I3ed3d964921fa051c94383b0676f83618439db50
Bug-Url: https://bugzilla.redhat.com/1273378
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java
3 files changed, 80 insertions(+), 18 deletions(-)

Approvals:
  Tal Nisan: Passed CI tests
  Roy Golan: Verified
  Maor Lipchuk: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49429
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3ed3d964921fa051c94383b0676f83618439db50
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list