Change in ovirt-engine[master]: core: before unlock a VM, fetch it from the DB

mlipchuk at redhat.com mlipchuk at redhat.com
Tue Dec 8 06:29:49 UTC 2015


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: before unlock a VM, fetch it from the DB
......................................................................


core: before unlock a VM, fetch it from the DB

The VM which is used to be unlocked is the VM from the meory, so the VM
might be with DOWN status although it was locked on the proccess.
Since CoCo handle the class in the memory (unlike the Async Task
functionality), after commiting/undo a previewed Cinder snapshot, the VM
from the memory is being unlocked but since the status of the memory of
the VM is DOWN, the engine doesn't unlock it.

The proposed fix is to make the VM property to be null in order to refresh
the VM status from db.

Bug-Url: https://bugzilla.redhat.com/1256048
Bug-Url: https://bugzilla.redhat.com/1256049

Change-Id: I7edd4e8b23277c57939bd5e965eb4da29e3600d3
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/49418
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7edd4e8b23277c57939bd5e965eb4da29e3600d3
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list