Change in ovirt-engine[master]: engine: CommitNetworkChanges only in case that it's known as...

alkaplan at redhat.com alkaplan at redhat.com
Thu Dec 10 13:06:55 UTC 2015


Alona Kaplan has submitted this change and it was merged.

Change subject: engine: CommitNetworkChanges only in case that it's known as dirty
......................................................................


engine: CommitNetworkChanges only in case that it's known as dirty

netConfigDirty is a 3-state Boolean. The patch negates the previous
behavior regarding NULL value. Now the config isn't being committed
in case of NULL.
That is to prevent cases that an unknown config is committed.

Change-Id: Ie592306052a315d6ecf6aa4470e2144e631d4c41
Bug-Url: https://bugzilla.redhat.com/1271273
Signed-off-by: Yevgeny Zaspitsky <yzaspits at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentHostSetupNetworksCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Alona Kaplan: Looks good to me, approved; Passed CI tests
  Moti Asayag: Looks good to me, but someone else must approve
  Yevgeny Zaspitsky: Verified



-- 
To view, visit https://gerrit.ovirt.org/50205
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie592306052a315d6ecf6aa4470e2144e631d4c41
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list