Change in ovirt-engine[master]: core: VdsBrokerObjectsBuilder#numaNodeComparator
amureini at redhat.com
amureini at redhat.com
Mon Dec 14 21:11:59 UTC 2015
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VdsBrokerObjectsBuilder#numaNodeComparator
......................................................................
core: VdsBrokerObjectsBuilder#numaNodeComparator
Clean up the code by using Comparator's function references instead of
re-implementing this logic inline.
As a side effect, this patch fixes a theoretical bug where the previous
comparator violates java's contract for two VdsNumaNodes with the same
index.
Change-Id: Ifc834c26915cc1e7c3a8b3c103acfe8e1d6bd698
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 1 insertion(+), 8 deletions(-)
Approvals:
Allon Mureinik: Verified; Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50448
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc834c26915cc1e7c3a8b3c103acfe8e1d6bd698
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list