Change in ovirt-engine[master]: core: as MacPool is initialized in postconstruct, there's no...

masayag at redhat.com masayag at redhat.com
Tue Dec 15 07:33:26 UTC 2015


Moti Asayag has submitted this change and it was merged.

Change subject: core: as MacPool is initialized in postconstruct, there's no need for initialized checking
......................................................................


core: as MacPool is initialized in postconstruct, there's no need for initialized checking

… since weld will initialize it only once. On top of it, if
postconstruct fails with runtimeexception, bean is not constructed and
injected, producing failure.

Change-Id: I508c4887662577a7694ca25b0158b810bb8c792f
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDc.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolPerDcTest.java
2 files changed, 2 insertions(+), 62 deletions(-)

Approvals:
  Martin Mucha: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47683
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I508c4887662577a7694ca25b0158b810bb8c792f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list