Change in ovirt-engine[ovirt-engine-3.6]: backend: Fix sound device handling on ppc desktops

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: backend: Fix sound device handling on ppc desktops
......................................................................


backend: Fix sound device handling on ppc desktops

When adding a VM to pool via rest API we automatically fall back to enabling
sound device only based on the VM's desktop type.

Extracted check already present in AddVmCommand into VmDeviceUtils and used it
to replace all ocurrences of setSoundDeviceEnabled(vmType == DESKTOP).

Change-Id: I6459f5cfb51b4dbdd53af6e7138e690ec4bb9c80
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1291626
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
7 files changed, 54 insertions(+), 28 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Martin Betak: Verified
  Shmuel Leib Melamud: Looks good to me, but someone else must approve
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/50676
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6459f5cfb51b4dbdd53af6e7138e690ec4bb9c80
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>