Change in ovirt-engine[ovirt-engine-3.6]: core: compare custom properties against template on add vm

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: core: compare custom properties against template on add vm
......................................................................


core: compare custom properties against template on add vm

We should require permission for action-group of type
ActionGroup.CHANGE_VM_CUSTOM_PROPERTIES on add-VM only if the
custom properties of the VM to add are different than the ones
defined in the template it is based on.

Currently, since we only check whether the VM is defined with
custom properties or not and by default the VM gets the custom
properties of its template, users cannot create a VM that is
based on template which is defined with custom properties
without having these extra permissions.

Change-Id: I1c3bb293085cc26ad93f470c4d7e151cc2af08f0
Bug-Url: https://bugzilla.redhat.com/1284472
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Passed CI tests
  Shahar Havivi: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/51137
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c3bb293085cc26ad93f470c4d7e151cc2af08f0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>