Change in ovirt-engine[master]: restapi: wrong SDs on templates disks entities

derez at redhat.com derez at redhat.com
Mon Feb 16 19:30:22 UTC 2015


Daniel Erez has submitted this change and it was merged.

Change subject: restapi: wrong SDs on templates disks entities
......................................................................


restapi: wrong SDs on templates disks entities

Removed deprecated logic from 'BackendReadOnlyDisksResource -> list'
(used only by BackendTemplateDisksResource), which fetches
storage domains using GetStorageDomainsByVmTemplateId and adds
it to all disks in the collection. As a result, all disks contain
all storage domains IDs - a correct behavior pre-MSD (back when
we had a copy template action).

Change-Id: Ica6787d39fbdec49250d4a3a385c9027e288c24e
Bug-Url: https://bugzilla.redhat.com/1193079
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDisksResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDisksResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDisksResourceTest.java
3 files changed, 4 insertions(+), 75 deletions(-)

Approvals:
  Juan Hernandez: Looks good to me, approved
  Daniel Erez: Verified
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/37820
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ica6787d39fbdec49250d4a3a385c9027e288c24e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list