Change in ovirt-engine[master]: core: Remove code duplication in VdsNetworkInterface.toString()

[lvernia at redhat.com]

Lior Vernia has submitted this change and it was merged.

Change subject: core: Remove code duplication in VdsNetworkInterface.toString()
......................................................................


core: Remove code duplication in VdsNetworkInterface.toString()

Changed the serialization of VdsNetworkInterface to re-use code
instead of duplicate it. New serialized attributes were being added
only to VdsNetworkInterface by unsuspecting developers, yet these
would not show in the engine log, for example on Setup Networks
commands, as the base class method was being overridden by subclasses
(where the new attributes weren't being added).

Change-Id: I94bbf7113e848f6ca8ae4a38e46303050d653135
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Bond.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Nic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Vlan.java
4 files changed, 63 insertions(+), 145 deletions(-)

Approvals:
  Alona Kaplan: Looks good to me, approved
  Lior Vernia: Verified



-- 
To view, visit http://gerrit.ovirt.org/36215
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94bbf7113e848f6ca8ae4a38e46303050d653135
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server