Change in ovirt-engine[master]: core: Make ConfigValuesTest more informative

tnisan at redhat.com tnisan at redhat.com
Tue Jan 6 10:48:42 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: Make ConfigValuesTest more informative
......................................................................


core: Make ConfigValuesTest more informative

Currently the test stops after finding one missing values, it makes no
sense to keep runing the test over and over until you fix all missing
values issues so the missing values will be aggregated in a list.
Aside for that, the logging of the missing value is swallowed between all
the other tests and the test summary does not show which key was missing
so the missing values are also added to the test result now

Change-Id: Icb921f082350d19006c7b977c2697009bbc2a10d
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/ConfigValuesTest.java
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Tal Nisan: Verified
  Allon Mureinik: Looks good to me, but someone else must approve
  Yair Zaslavsky: Looks good to me, approved
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/36551
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icb921f082350d19006c7b977c2697009bbc2a10d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list