Change in ovirt-engine[ovirt-engine-3.5]: core: do not copy RNG device from instance type if not possible

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: core: do not copy RNG device from instance type if not possible
......................................................................


core: do not copy RNG device from instance type if not possible

The rng device was copied from the instance type to newly created VM without
checking if the virtio rng is actually supported on this cluster.

Fixed by extracting the logic to a standalone validator and using this
validator in commands and also in VmDeviceUtils.

Change-Id: Ic016df28bd0484735c74308750fe03ab9036f59d
Bug-Url: https://bugzilla.redhat.com/1177234
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractRngDeviceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRngDeviceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateRngDeviceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VirtIoRngValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateRngDeviceTest.java
6 files changed, 60 insertions(+), 20 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/36829
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic016df28bd0484735c74308750fe03ab9036f59d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server