Change in ovirt-engine[master]: webadmin: fix DirectLUN disk creation

derez at redhat.com derez at redhat.com
Tue Jan 13 19:29:45 UTC 2015


Daniel Erez has submitted this change and it was merged.

Change subject: webadmin: fix DirectLUN disk creation
......................................................................


webadmin: fix DirectLUN disk creation

As progress start/stop event is no longer invoked on the model,
external disk panel isn't being displayed on VmDiskPopupWidget
(i.e. New disk popup is missing the LUNs list in DirectLUN view).
Hence,
* Removing progress indication from the inner view (external
  disk panel) and rely on the popup progress.
* Pass proper target to AsyncQuerys on SanStorageModel/SanStorageModelBase
  to ensure progress on Disk and Storage popups.

Change-Id: Ib5f30df2ba2f4591f6daaa6144b1af8a0d09bfd4
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java
3 files changed, 26 insertions(+), 52 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Daniel Erez: Verified



-- 
To view, visit http://gerrit.ovirt.org/36831
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5f30df2ba2f4591f6daaa6144b1af8a0d09bfd4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list