Change in ovirt-engine[master]: core: ovf_store isn't added

gchaplik at redhat.com gchaplik at redhat.com
Sun Jan 25 14:04:26 UTC 2015


Gilad Chaplik has submitted this change and it was merged.

Change subject: core: ovf_store isn't added
......................................................................


core: ovf_store isn't added

When disk is added and there is no active user- currently
only for ovf_store disk, disk profile permission check causes
NPE.

Since user is null when command is invoked by the internally,
we can skip the permission check.

Bug-Url: https://bugzilla.redhat.com/1185615
Signed-off-by: Gilad Chaplik <gchaplik at redhat.com>
Change-Id: I0ab3247d0f80e2f5123aace3fac58bee2a8a7b8d
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Gilad Chaplik: Verified
  Allon Mureinik: Looks good to me, approved
  Liron Aravot: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/37267
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ab3247d0f80e2f5123aace3fac58bee2a8a7b8d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list