Change in ovirt-engine[ovirt-engine-3.5]: core: Validate the return value of an internal query.

[tnisan at redhat.com]

Tal Nisan has submitted this change and it was merged.

Change subject: core: Validate the return value of an internal query.
......................................................................


core: Validate the return value of an internal query.

Use the internal query return value to check if it has been succeeded or
failed when calling getExistingStorageDomainList, so we can be sure that
the return object value is a list and not null in case of a failure.

Change-Id: I7a4ddd8f0e290981f1d583dfdb1722f7864b1f6d
Bug-Url: https://bugzilla.redhat.com/1186372
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetFileStorageDomainsWithAttachedStoragePoolGuidQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetFileStorageDomainsWithAttachedStoragePoolGuidQueryTest.java
2 files changed, 49 insertions(+), 10 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, but someone else must approve
  Allon Mureinik: Looks good to me, approved
  Maor Lipchuk: Verified



-- 
To view, visit http://gerrit.ovirt.org/37321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7a4ddd8f0e290981f1d583dfdb1722f7864b1f6d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server