Change in ovirt-engine[master]: sercon: fix 'manual intervention required' text

sbonazzo at redhat.com sbonazzo at redhat.com
Mon Jul 6 13:20:05 UTC 2015


Sandro Bonazzola has submitted this change and it was merged.

Change subject: sercon: fix 'manual intervention required' text
......................................................................


sercon: fix 'manual intervention required' text

Make the 'Required manual intervention'
message consistent, by moving the string in
a constant, and reusing ewverywhere.

Moreover, this also improves i18n:
- the text of the disclaimer requiring the admin
  to run commands should be localized, but
- the commands themselves should not!

Since the commands may vary, this actually make it
possible to localize the text.

Change-Id: Ic641e5e84ebfe5efcc2b0eecbe0e7b9934c98e4c
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/constants.py
M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py
M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/pki.py
3 files changed, 24 insertions(+), 29 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Yedidyah Bar David: Looks good to me, but someone else must approve
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/43105
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic641e5e84ebfe5efcc2b0eecbe0e7b9934c98e4c
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list