Change in ovirt-engine[master]: core: Don't use Matchers.any

amureini at redhat.com amureini at redhat.com
Wed Jul 15 09:47:52 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Don't use Matchers.any
......................................................................


core: Don't use Matchers.any

Changed StorageDomainToPoolRelationValidatorTest to use the actual IDs
from the test objects (the storage domain and storage pool) instead of
any(Guid.class). This makes the test stricter and helps validate we pass
the correct objects around.

Change-Id: I245a032fd666d853635540cd3a0625266e1eec40
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidatorTest.java
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Amit Aviram: Looks good to me, but someone else must approve
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/43609
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I245a032fd666d853635540cd3a0625266e1eec40
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list