Change in ovirt-engine[master]: core: handle failure in vms monitoring

ofrenkel at redhat.com ofrenkel at redhat.com
Wed Jul 15 15:53:38 UTC 2015


Omer Frenkel has submitted this change and it was merged.

Change subject: core: handle failure in vms monitoring
......................................................................


core: handle failure in vms monitoring

currently if exception is thrown during vms monitoring (mostly during
analyzing) the exception is not caught.
since monitoring is always called from scheduler/event dispatcher, the
only log is ~:
[] Failed to invoke scheduled method perform: null
which is useless

so instead, changed VmsMonitoring.perform() to catch the exception and
log it.

Change-Id: I2c7c86f2b4b6d8041717b284c9dd07a84ada6969
Signed-off-by: Omer Frenkel <ofrenkel at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Omer Frenkel: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/43671
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2c7c86f2b4b6d8041717b284c9dd07a84ada6969
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list