Change in ovirt-engine[master]: core: Java style constants

amureini at redhat.com amureini at redhat.com
Thu Jul 16 16:51:19 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Java style constants
......................................................................


core: Java style constants

Fixed the conceptual constants in VdsBrokerObjectBuilderTest to be
private static final and to be named in UPPER_CASE, as per Java's coding
standard.

Change-Id: Ib81b146f49708cd2d8ae562d352d955cb3500866
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/43737
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib81b146f49708cd2d8ae562d352d955cb3500866
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list