Change in ovirt-engine[master]: core: capped exponential backoff for CoCo CommandExecutor

amureini at redhat.com amureini at redhat.com
Tue Jul 21 16:05:33 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: capped exponential backoff for CoCo CommandExecutor
......................................................................


core: capped exponential backoff for CoCo CommandExecutor

Some commands run by CoCo complete quickly and would benefit from faster
polling; however, some may take longer to complete and polling too often
consumes unnecessary CPU.  This is a good use case for capped
exponential backoff, which is implemented here purely in-memory.

New commands will poll 1 second, doubling until reaching the
AsyncCommandPollingRateInSeconds configuration value.

Change-Id: Id89929ba0d8aa8e80ae358acbe7cc763a92be135
Signed-off-by: Greg Padgett <gpadgett at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
4 files changed, 36 insertions(+), 8 deletions(-)

Approvals:
  Greg Padgett: Verified
  Ravi Nori: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/43428
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id89929ba0d8aa8e80ae358acbe7cc763a92be135
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list