Change in ovirt-engine[master]: webadmin: Remove the "selectedItem" terminology from Storage...

derez at redhat.com derez at redhat.com
Thu Jul 23 13:31:19 UTC 2015


Daniel Erez has submitted this change and it was merged.

Change subject: webadmin: Remove the "selectedItem" terminology from StorageModel.
......................................................................


webadmin: Remove the "selectedItem" terminology from StorageModel.

privateAvailableiStorageItems List now appears only behind the scenes. We have
StorageType and StorageDomainType lists seperatly now, which *are*
displayed. Though this list is no longer displayed, it plays a great logical
part. This patch removes the list.
This is the first setp in making StorageModel inherit from Model instead
of ListModel<IStorageModel> .

Change-Id: I5d16972f8155ccea4505fd268683cbe92b079a84
Signed-off-by: Vered Volansky <vvolansk at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java
7 files changed, 145 insertions(+), 131 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Vered Volansky: Verified



-- 
To view, visit https://gerrit.ovirt.org/43317
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5d16972f8155ccea4505fd268683cbe92b079a84
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list