Change in ovirt-engine[master]: core: use updateVMDynamicData also for events

[ofrenkel at redhat.com]

Omer Frenkel has submitted this change and it was merged.

Change subject: core: use updateVMDynamicData also for events
......................................................................


core: use updateVMDynamicData also for events

currently there is a special vm dynamic builder for event data,
since it is planed that events will provide more information,
it is better to use the 'full' builder that is used for stats cycle.

this reuired 2 changes:
* cleaning field initialization if field is missing on xmlStruct - this
  was not needed since all the fields already null by default,
  or set with the same value in the default ctor.

* move post-processing of display ip inside this flow, it anyway makes
  sense, and a bug it was called only on stats, thus required passing
  the host as parameter from all callers.

Change-Id: Id4331b019fc48fe62d35b6f0b8e68e0765348dcf
Signed-off-by: Omer Frenkel <ofrenkel at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVmStatsRefresher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ChangeDiskVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ChangeFloppyVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PauseVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java
9 files changed, 67 insertions(+), 109 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Omer Frenkel: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/43450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4331b019fc48fe62d35b6f0b8e68e0765348dcf
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org