Change in ovirt-engine[master]: core: ActivateStorageDomainCommandTest lists

amureini at redhat.com amureini at redhat.com
Tue Jul 28 06:42:24 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: ActivateStorageDomainCommandTest lists
......................................................................


core: ActivateStorageDomainCommandTest lists

Remove usage of ArrayList from the test and replace it with explicit
usages of Collections.emptyList() and Collections.singletonList(Object),
which are both clearer to understand and less bug prone in the future.

Change-Id: Id497f77375030ee1ef0b4f735ae2bf044b027ffd
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommandTest.java
1 file changed, 5 insertions(+), 6 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/43838
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id497f77375030ee1ef0b4f735ae2bf044b027ffd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list