Change in ovirt-engine[master]: engine: HostsetupNetworksCommand- small bug fixes

alkaplan at redhat.com alkaplan at redhat.com
Tue Jul 28 13:22:56 UTC 2015


Alona Kaplan has submitted this change and it was merged.

Change subject: engine: HostsetupNetworksCommand- small bug fixes
......................................................................


engine: HostsetupNetworksCommand- small bug fixes

1. The attachment was always compared to the base nic.
2. completion of the networkId and network name of the exisiting
attahcments.
3. Fix sync error message.
4. MapNetworkAttachments mapped between nicName to single attachment.
It is wrong since single base nic can have multiple attachments.

Change-Id: I5c249dda94b572291bf0428e279ae8bc61549ba0
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/MapNetworkAttachments.java
3 files changed, 30 insertions(+), 16 deletions(-)

Approvals:
  Alona Kaplan: Verified; Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/43722
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5c249dda94b572291bf0428e279ae8bc61549ba0
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list