Change in ovirt-engine[master]: webadmin: graphics properties not handled properly

tjelinek at redhat.com tjelinek at redhat.com
Wed Jul 29 11:30:05 UTC 2015


Tomas Jelinek has submitted this change and it was merged.

Change subject: webadmin: graphics properties not handled properly
......................................................................


webadmin: graphics properties not handled properly

Couple of problems:
- for instance types / blank template first the selected items of the graphics
properties have been set and than the grapics devices has been dowloaded and
they reset the settings.
Fixed by making sure to call the setup in the correct order.

- the graphics has to be updated also after the OS / cluster changes
- instance type manager also set the graphics properties in the incorrect order
- the previously selected consoles in UnitVmModel were not remembered

Change-Id: I6a672b05aa64ba0a01861bec4deb5afd9b288071
Bug-Url: https://bugzilla.redhat.com/1241587
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/BlankTemplateModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingNonClusterModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java
4 files changed, 92 insertions(+), 83 deletions(-)

Approvals:
  Tomas Jelinek: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Martin Betak: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/43955
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a672b05aa64ba0a01861bec4deb5afd9b288071
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list