Change in ovirt-engine-sdk[master]: sdk: Avoid altering dictionary while removing elements

juan.hernandez at redhat.com juan.hernandez at redhat.com
Tue Jun 2 13:10:15 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: sdk: Avoid altering dictionary while removing elements
......................................................................


sdk: Avoid altering dictionary while removing elements

Currently the "clear" method of the "Cache" class iterates the keys of
the dictionary and removes them, but this causes errors in Python 3.
This patch changes that methods so that it makes a copy of the list of
keys and iterates it intead of the original one.

Change-Id: Iff458d9e432c47e4c5d9ef7ec3e1178d718be497
Related: https://bugzilla.redhat.com/1096137
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M src/ovirtsdk/infrastructure/cache.py
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me; Ready for merge
  Jenkins CI: Verified; Looks good to me; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/41352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iff458d9e432c47e4c5d9ef7ec3e1178d718be497
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list