Change in ovirt-engine[master]: frontend: Add missing columns to HostDevice subtabs
tjelinek at redhat.com
tjelinek at redhat.com
Wed Jun 3 11:53:13 UTC 2015
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Add missing columns to HostDevice subtabs
......................................................................
frontend: Add missing columns to HostDevice subtabs
Added missing columns and fixed column sizes of host device
table in VM and Host sub tabs to make it consistent with
AddVmHostDevicePopupView.
Also since in VM and Host sub tabs is always displayed the
same information, extracted the commonalities to
HostDeviceModelBaseTable.
Change-Id: I484d0607bb27118058bef08c628c8a3bc8587fc9
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/AddVmHostDevicePopupView.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/HostDeviceColumnHelper.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/HostDeviceModelBaseTable.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/HostDeviceModelTable.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostDeviceView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/VmHostDeviceModelTable.java
6 files changed, 143 insertions(+), 143 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Looks good to me, but someone else must approve
Jenkins CI: Verified; Looks good to me, but someone else must approve
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/41830
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I484d0607bb27118058bef08c628c8a3bc8587fc9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
More information about the Engine-commits
mailing list