Change in ovirt-engine[master]: engine: Inject dependencies to FutureVdsCommand

oourfali at redhat.com oourfali at redhat.com
Mon Jun 8 09:41:01 UTC 2015


Oved Ourfali has submitted this change and it was merged.

Change subject: engine: Inject dependencies to FutureVdsCommand
......................................................................


engine: Inject dependencies to FutureVdsCommand

Without injecting the dependencies, auditing an event to log would
fail with NPE when trying to obtain the AuditLogDirector.

In addition, the c'tor of VdsBrokerCommand should have taken care of
initializing the 'vds' member of it.

Change-Id: I975a2752c21d60dacb452714d0910dc658897a4a
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java
2 files changed, 14 insertions(+), 9 deletions(-)

Approvals:
  Marcin Mirecki: Looks good to me, but someone else must approve
  Jenkins CI: Verified; Looks good to me, but someone else must approve
  Moti Asayag: Verified
  Oved Ourfali: Looks good to me, approved
  Yevgeny Zaspitsky: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/42026
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I975a2752c21d60dacb452714d0910dc658897a4a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list