Change in ovirt-engine[master]: core: error fix & simplification

ahadas at redhat.com ahadas at redhat.com
Wed Jun 10 06:57:48 UTC 2015


Arik Hadas has submitted this change and it was merged.

Change subject: core: error fix & simplification
......................................................................


core: error fix & simplification

• it seems that storage_pool_iso_map.status can be null, thus status
!= StorageDomainStatus.Active produces npe.

• refreshIsoDomain was overgrown with several unneeded variables and
complex syntax, which could be simplified.

Bug-Url: https://bugzilla.redhat.com/1200952
Change-Id: I109fb2036e737e6a7bbc9701ee9e8ca35b1f552d
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
1 file changed, 53 insertions(+), 51 deletions(-)

Approvals:
  Martin Mucha: Verified
  Jenkins CI: Verified; Looks good to me, but someone else must approve
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/41271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I109fb2036e737e6a7bbc9701ee9e8ca35b1f552d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list