Change in ovirt-engine[master]: webadmin, engine : Error handling in geo-rep create

[kmayilsa at redhat.com]

Kanagaraj M has submitted this change and it was merged.

Change subject: webadmin, engine : Error handling in geo-rep create
......................................................................


webadmin, engine : Error handling in geo-rep create

The failure message of a command will be set in
1. canDoAction failure
FrontendActionAsyncResult#getReturnValue#getCanDoActionMessages
2. Command failure from Vds
FrontendActionAsyncResult#getReturnValue#getFault#getMessage
3. UI error handling assumed the only source of error to be 2

1, 2 and 3 necessiated to allow UI framework to handle erroneous
conditions as it is capable of doing this conditional handling
as in Frontend#handleActionResult

Along with the above there was an error in propogation of error
from internal commands to the command invoking them and hence
removed error handling from internal commands and propogated(using
CommandBase#propagateFailure)them to the command utilising them.

Change-Id: I3f7beec04869f7417f6f691aa33cd8ba67c72e75
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1230353
Signed-off-by: Anmol Babu <anbabu at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetupGlusterGeoRepMountBrokerInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHostPubKeyToSlaveInternalCommand.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java
5 files changed, 64 insertions(+), 42 deletions(-)

Approvals:
  anmolbabu: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/42300
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f7beec04869f7417f6f691aa33cd8ba67c72e75
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu at redhat.com>
Gerrit-Reviewer: automation at ovirt.org